Skip to content

Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement #60

Closed

Description

@jarek-foksa

The current draft of the SVG spec defines dataset attribute on the SVGElement interface while HTML 5 spec defines it on the HTMLElement interface.

Is there any particular reason why dataset couldn't be defined just once on the Element interface like other similar attributes such as classList?

Activity

  1. AmeliaBR commented on Jul 11, 2016

    @AmeliaBR
    Contributor

    I don't think dataset can be generalized to all XML languages (because of the expectations it creates re valid attributes), so putting it on Element is unlikely to happen.

    However, it may be preferable to define it within the DOM specs as a "mixin" interface that can then be implemented by both HTMLElement and SVGElement. That would ensure that we had one, canonical definition that would always be updated consistently.

    Anyone want to take responsibility for looking into this possibility with HTML WG and WHATWG?

  2. added this to the CR milestone on Jul 11, 2016
  3. removed this from the CR milestone on Jul 28, 2016
  4. dstorey commented on Mar 7, 2018

    @dstorey
    Member

    There is now a PR for this and blur/focus/tabindex in HTML whatwg/html#3543

  5. self-assigned this
    on Mar 23, 2018
  6. dstorey commented on Mar 23, 2018

    @dstorey
    Member

    To be clear, we're moving this to a mixin in HTML (tests pending) that will still be included on SVGElement, rather than moving it to Element.

  7. added a commit that references this issue on Mar 23, 2018
  8. annevk commented on Mar 23, 2018

    @annevk
    Member

    In the above referenced commit I said that it fixed this issue, but I guess what still remains is that you need to remove dataset from SVGElement's IDL.

  9. AmeliaBR commented on Mar 23, 2018

    @AmeliaBR
    Contributor

    Yep, marking this as "needs edits" and updating the title to match the chosen solution.

  10. changed the title [-]Move dataset IDL attribute from SVGElement to Element[/-] [+]Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement[/+] on Mar 23, 2018
  11. AmeliaBR commented on Mar 23, 2018

    @AmeliaBR
    Contributor

    This brings up again the issue of whether SVG wants to link normatively to WHATWG interfaces; we currently reference W3C versions. With the new WHATWG royalty commitments, it's probably less of an issue, but still a little messy & political to make the change.

    I'll file an issue on W3C/html to ask if they can mirror the change, but not sure how long that might take.

  12. domenic commented on Mar 24, 2018

    @domenic

    We would appreciate it if in working collaboratively with us, you did not then turn around and request that another group copy our work so that you can proceed to ignore our work in your spec :(.

  13. css-meeting-bot commented on Mar 26, 2018

    @css-meeting-bot
    Member

    The Working Group just discussed (Revisiting) Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement.

    The full IRC log of that discussion <BogdanBrinza> topic: (Revisiting) Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement
    <BogdanBrinza> GitHub: https://github.com//issues/60
    <BogdanBrinza> dstorey: SVG 2.0 current draft already links to the Fetch specification so we won't make things worse in PR if we add another one
    <BogdanBrinza> Resolution: Link to WHATWG spec now to resolve github.com//issues/60, while Liam is confirming this with W3C
  14. added a commit that references this issue on Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions