Review agent info logs - #36234
Merged
jotacarma90 merged 1 commit intoMay 25, 2026
Merged
Review agent info logs#36234jotacarma90 merged 1 commit into
jotacarma90 merged 1 commit into
Conversation
Antoniogm03
marked this pull request as draft
May 20, 2026 09:26
Antoniogm03
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
from
May 20, 2026 11:51
b9f94bc to
43c4d75
Compare
Antoniogm03
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
3 times, most recently
from
May 21, 2026 11:35
b5ae0e8 to
b44b16c
Compare
jotacarma90
requested changes
May 21, 2026
jotacarma90
left a comment
Member
There was a problem hiding this comment.
-
sca: 6 lines at startup today. Keep only
Started (pid: X),Scan started.andScan ended.. The rest (Module enabled.,SCA initialized.,Starting module.,Module scan on start.) to DEBUG. -
syscollector:
Module enabled.andStarting module.to DEBUG.Module started.becomesStarted (pid: X). -
agent-info:
Module enabled.,Successfully loaded agent-info libraryandAgentInfo initialized.to DEBUG. Should emit a singleStarted (pid: X)line. -
agent-upgrade: change
Module started.toStarted (pid: X). -
content_manager, inventory_sync, router, vulnerability_scanner:
Module enabled.to DEBUG. They should emitStarted (pid: X)at startup. TheModule finished.line at shutdown can stay at INFO.
Antoniogm03
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
2 times, most recently
from
May 22, 2026 09:04
9d12718 to
9f34178
Compare
Antoniogm03
marked this pull request as ready for review
May 22, 2026 09:06
jotacarma90
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
2 times, most recently
from
May 22, 2026 17:04
254b5ad to
04c06c2
Compare
jotacarma90
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
from
May 22, 2026 17:47
04c06c2 to
9354f75
Compare
jotacarma90
added a commit
to wazuh/qa-integration-framework
that referenced
this pull request
May 24, 2026
Align syscollector module patterns with the new log messages introduced in wazuh/wazuh#36234: - CB_MODULE_STARTING: "Starting Syscollector." -> "Starting module." - CB_MODULE_STARTED: "INFO: Module started." -> "INFO: Started (pid: N)." (the explicit "Module started." log was removed; STARTUP_MSG is emitted instead). - CB_SYSCOLLECTOR_DISABLED: "Module disabled. Exiting..." (three dots) -> "Module disabled. Exiting." (single period, matches new wording).
jotacarma90
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
from
May 24, 2026 15:46
9354f75 to
72174b8
Compare
jotacarma90
force-pushed
the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
from
May 24, 2026 18:57
72174b8 to
c2373cd
Compare
jotacarma90
deleted the
enhancement/36112-review-agent-info-logs-moved-to-debug-and-silence-redundant-messages
branch
May 25, 2026 08:25
This was referenced May 26, 2026
pull Bot
pushed a commit
to kp-forks/wazuh
that referenced
this pull request
May 27, 2026
…_syscollector.c PR wazuh#36234 moved syscollector's startup INFO log from `Syscollector::syncLoop()` (post-DataClean) to `wm_sys_main()` (pre-DataClean) without bumping the test's `CB_SCAN_STARTED` timeout. In `test_syscollector_collectors_disabled` the post-DataClean window stayed at 10s, but the gap now includes the full `handleNotifyDataClean` retry budget (`m_dataCleanRetries` × 60s — typically 3 × 60s) because the test env's remoted_simulator does not ack DataClean. Three parametrized cases (packages_disabled, packages_processes_disabled, network_disabled) consequently fail on every Linux/Windows IT run. This was not caught when wazuh#36234 landed because the syscollector IT path triggers in `.github/test_modules_linux.json` and `.github/test-modules-windows.json` only listed `src/wazuh_modules/syscollector/**` and `src/config/src/wmodules-syscollector.c`; PR wazuh#36234's change lives in `src/wazuh_modules/src/wm_syscollector.c`, so no IT shard was selected on that PR. - Bump the `CB_SCAN_STARTED` timeout to 240s and comment why. - Add `src/wazuh_modules/src/wm_syscollector.c` to the syscollector IT trigger paths on Linux and Windows so future changes to the wm-side entry point run the IT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to review the agent logs and determine which logs should be uploaded to
minfoand which ones should be retained.Proposed Changes
We propose uploading the following logs to minfo:
start_agent.cfile, upload the log entry “Trying to connect to server”logcollector.cfile, upload the module's startup logfim_scan.cfile, upload the log forFIM_FREQUENCY_STARTEDrun_check.cfile, upload the log entries forFIM_DAEMON_STARTEDandFIM_FREQUENCY_TIMEwm_agent_info.cfile, upload the startup log for the module and the library loading logwm_sca.cfile, upload the module's start, enable, and disable logswm_syscollector.cfile, upload the module's startup log.It is proposed to send the following logs to mdebug1:
agent_info_impl.cppfile, download the pause and triggering log for the modulesca_impl.cppfile, download the module's run log, the logs for the enabled, initialized, and starting modules.The logs have been standardized so that the startup and shutdown logs have the same structure, and a duplicate “Start” log from the agent-info module has been removed.
Results and Evidence
Review Checklist