Repository navigation
Conversation
Contributor
Author
|
I guess we need to check if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
PackerLoadto take no arguments and in that case query the user for the plugin to load usingvim.ui.select.To do this a bit more cleanly I changed the command to be created with the lua api instead of
vim.cmd. Maybe all commands should be changed to that but I think that's anyway the plan for #1042.Also, is
packer.loaderconsidered part of the public api? Since this version changes it's expected argument. Could keep the same behaviour ofpacker.loaderthough if needed and have another internal function which is called byPackerLoad.