[ComputePressure] Move privacy tests from Blink to content/browser. - #42653
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 20, 2023
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
8 times, most recently
from
October 26, 2023 07:25
da548de to
5eb4bd8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
from
October 30, 2023 03:14
5eb4bd8 to
2fbc5e0
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
from
November 9, 2023 07:35
2fbc5e0 to
68b0681
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
6 times, most recently
from
November 28, 2023 13:45
6028be2 to
77d2fba
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
from
November 29, 2023 02:44
77d2fba to
3bb8260
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
3 times, most recently
from
December 5, 2023 13:51
ff08f44 to
e60dcfc
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
3 times, most recently
from
December 12, 2023 07:22
e7e914b to
0730ea9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
from
December 14, 2023 04:44
0730ea9 to
b34d1b3
Compare
Privacy test is done in Blink currently. However, we can not get enough information in Blink to implement the improved privacy test [1]. This CL moves privacy test from Blink to content/browser. This CL also deletes privacy test related WPTs and adds corresponding browser tests, because we use MockPressureService in WPTs so these WPTs are no longer valid. This CL also renames PassesPrivacyTest() to HasImplicitFocus() according to the spec change [1]. [1] w3c/compute-pressure#238 Bug: 1500467, 1396177 Change-Id: I8c087951f5b804235a2dde4fa4e315159f400cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956687 Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1237389}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956687
branch
from
December 14, 2023 06:00
b34d1b3 to
14ff524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Privacy test is done in Blink currently. However, we can not get
enough information in Blink to implement the improved privacy
test [1]. This CL moves privacy test from Blink to content/browser.
This CL also deletes privacy test related WPTs and adds corresponding
browser tests, because we use MockPressureService in WPTs so these
WPTs are no longer valid.
This CL also renames PassesPrivacyTest() to HasImplicitFocus()
according to the spec change [1].
[1] w3c/compute-pressure#238
Bug: 1500467, 1396177
Change-Id: I8c087951f5b804235a2dde4fa4e315159f400cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956687
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1237389}