Repository navigation
[Gecko Bug 1791226] Improve line-clamp behavior with padding / nested blocks. - #48696
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 18, 2024
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This matches Blink with border / padding in nested blocks, and seems worth doing even if we paint the nested lines. Follow-up patch will prevent painting the nested lines. Differential Revision: https://phabricator.services.mozilla.com/D157572 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226 gecko-commit: 1c543fc925a7d0e1dc8b8f57dad98e170c233bed gecko-reviewers: layout-reviewers, dshin
moz-wptsync-bot
force-pushed
the
gecko/1791226
branch
2 times, most recently
from
October 19, 2024 01:54
cbd211f to
1718790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches Blink with border / padding in nested blocks, and seems
worth doing even if we paint the nested lines. Follow-up patch will
prevent painting the nested lines.
Differential Revision: https://phabricator.services.mozilla.com/D157572
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226
gecko-commit: 8396d1845d92124f4b50f6092ec7bf27a7f1c540
gecko-reviewers: layout-reviewers, dshin