Add WPTs for negotiating H265 with minimal level-id in SDP answers. - #49990
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
January 9, 2025 09:27
Add test coverage for w3c/webrtc-pc#3023 which unblocks merging the PR (it has "editors can integrate"). Specifically it should be possible to negotiate H265 even if the level-id is downgraded in the SDP answer (not throwing on level-id mismatch). - H265 is behind flags so a virtual test suite is added. - If bot lacks HW capabilities to do H265, the tests will PRECONDITION_FAILED. To avoid reverting tests we will allow the bots to both pass and fail, I filed crbug.com/388299759. Some of the tests FAIL even when they run: passing these tests will be covered by crbug.com/381407888. Bug: chromium:381407888, webrtc:41480904, chromium:388299759 Change-Id: Ie017560b4310418a4c9ed854dcb09136b9b446e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148192 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/main@{#1404052}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6148192
branch
from
January 9, 2025 09:27
8962bed to
86a873b
Compare
wpt-pr-bot
approved these changes
Jan 9, 2025
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for w3c/webrtc-pc#3023 which
unblocks merging the PR (it has "editors can integrate"). Specifically
it should be possible to negotiate H265 even if the level-id is
downgraded in the SDP answer (not throwing on level-id mismatch).
PRECONDITION_FAILED. To avoid reverting tests we will allow the bots
to both pass and fail, I filed crbug.com/388299759.
Some of the tests FAIL even when they run: passing these tests will be
covered by crbug.com/381407888.
Bug: chromium:381407888, webrtc:41480904, chromium:388299759
Change-Id: Ie017560b4310418a4c9ed854dcb09136b9b446e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148192
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/main@{#1404052}