Skip to content

Respect blocked port list for ICE-TCP connections - #21025

Merged
past merged 2 commits into
masterfrom
chromium-export-cl-1986070
Mar 25, 2024
Merged

Respect blocked port list for ICE-TCP connections#21025
past merged 2 commits into
masterfrom
chromium-export-cl-1986070

Conversation

@chromium-wpt-export-bot

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Bug: chromium:1038754
Change-Id: I51d99e7fffbb66a0478f03d674fb3699925fa3f8
Reviewed-on: https://chromium-review.googlesource.com/1986070
WPT-Export-Revision: 24420b66c5422d3e1bd74d78692efefa7e851e7f

wpt-pr-bot
wpt-pr-bot approved these changes Jan 3, 2020
View reviewed changes

@wpt-pr-bot wpt-pr-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot
chromium-wpt-export-bot force-pushed the chromium-export-cl-1986070 branch 2 times, most recently from 1357dc8 to 414e47d Compare January 8, 2020 11:24
Harald Alvestrand @chromium-wpt-export-bot
Respect blocked port list for ICE-TCP connections
e4c83d6 
Bug: chromium:1038754
Change-Id: I51d99e7fffbb66a0478f03d674fb3699925fa3f8
@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders
gsnedders deleted the chromium-export-cl-1986070 branch January 24, 2020 18:05
@gsnedders
gsnedders restored the chromium-export-cl-1986070 branch January 24, 2020 18:41
@Hexcles Hexcles reopened this Jan 24, 2020
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
@dontcallmedom

dontcallmedom commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

@web-platform-tests/admins if I were to update this PR to resolve the conflict, would anything break if it then got merged? (asking since this is coming from a chromium import)

@past

past commented Nov 15, 2023

Copy link
Copy Markdown
Member

I don't think so, but maybe @WeizhongX can confirm?

@WeizhongX

WeizhongX commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

I don't think so, but maybe @WeizhongX can confirm?

So we have a CL merged in 2020 but the corresponding PR has never landed?

Making change to an exported PR should be the same to make a new PR at upstream, so if there is no concurrent change in chromium, you should be fine. And the importer should be able to import the additional changes in this PR.

@community-tc-integration

community-tc-integration Bot commented Mar 20, 2024

Copy link
Copy Markdown
Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/VVMtzszcSfK0fuZsexdXPw/RvenwliCRJSZUdUeKVQpBQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/VVMtzszcSfK0fuZsexdXPw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/VVMtzszcSfK0fuZsexdXPw/RvenwliCRJSZUdUeKVQpBQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/VVMtzszcSfK0fuZsexdXPw"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-03-20T16:54:47.226Z

@community-tc-integration

community-tc-integration Bot commented Mar 20, 2024

Copy link
Copy Markdown
Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/VVMtzszcSfK0fuZsexdXPw/Jx-driBKSO-6D-vmGefKlg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/VVMtzszcSfK0fuZsexdXPw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/VVMtzszcSfK0fuZsexdXPw/Jx-driBKSO-6D-vmGefKlg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/VVMtzszcSfK0fuZsexdXPw"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-03-20T16:54:47.318Z

@dontcallmedom

dontcallmedom commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

the firefox stability error reported here has no relationship with content of the PR - @web-platform-tests/wpt-core-team help?

@past
past merged commit 0099557 into master Mar 25, 2024
@past
past deleted the chromium-export-cl-1986070 branch March 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees

No one assigned

Labels

chromium-export do not merge yet webrtc wg-s_webrtc wg-webrtc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chromium-wpt-export-bot @dontcallmedom @past @WeizhongX @wpt-pr-bot @gsnedders @Hexcles @moz-wptsync-bot