Repository navigation
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements - #37856
Merged
rniwa merged 1 commit intoJan 12, 2023
Conversation
wpt-pr-bot
requested review from
TakayoshiKochi,
annevk,
domenic,
foolip,
hayatoito,
jdm,
jgraham,
kojiishi,
snuggs and
zqzhang
January 11, 2023 00:18
1 task
annevk
approved these changes
Jan 11, 2023
annevk
left a comment
Member
There was a problem hiding this comment.
I think it would be good to add a historical test that asserts ariaErrorMessageElement is not implemented.
Contributor
Author
Good point. Adding that. |
rniwa
force-pushed
the
replace-ariaErrorMessageElement-with-ariaErrorMessageElements
branch
from
January 11, 2023 08:46
2c550ee to
2948659
Compare
…rorMessageElements This is WPT updates for w3c/aria#1802
rniwa
force-pushed
the
replace-ariaErrorMessageElement-with-ariaErrorMessageElements
branch
from
January 11, 2023 08:52
2948659 to
ce6f026
Compare
mrego
approved these changes
Jan 11, 2023
mrego
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for updating the tests.
rniwa
deleted the
replace-ariaErrorMessageElement-with-ariaErrorMessageElements
branch
January 12, 2023 05:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WPT updates for w3c/aria#1802