fix: load posthog-js via a consumer-injected loader#9
Merged
Conversation
WTS no longer imports posthog-js itself. The web client previously did a bare
`import("posthog-js")` guarded with `webpackIgnore` so consumers that don't
record (e.g. the Webiny admin app, which doesn't install posthog-js) could
still build. But webpackIgnore left a bare module specifier the browser can't
resolve at runtime, so session recording silently failed in bundled apps (no
traffic to s.webiny.com).
Add `SessionRecordingConfig.loadPostHog`, a loader the consumer supplies as
`() => import('posthog-js')`. The import resolves inside the consumer's bundle
(where posthog-js is installed), and the library contains no posthog-js
reference at all — so non-recording consumers build cleanly without
webpackIgnore. Recording is skipped with a warning if no loader is given.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WTS no longer imports posthog-js itself. The web client previously did a bare
import("posthog-js")guarded withwebpackIgnoreso consumers that don't record (e.g. the Webiny admin app, which doesn't install posthog-js) could still build. But webpackIgnore left a bare module specifier the browser can't resolve at runtime, so session recording silently failed in bundled apps (no traffic to s.webiny.com).Add
SessionRecordingConfig.loadPostHog, a loader the consumer supplies as() => import('posthog-js'). The import resolves inside the consumer's bundle (where posthog-js is installed), and the library contains no posthog-js reference at all — so non-recording consumers build cleanly without webpackIgnore. Recording is skipped with a warning if no loader is given.