Repository navigation
Focal point, why percentage and not focus point? #270
Description
Activity
- added a commit that references this issue
on Mar 4, 2021 You're right, the implementation didn't take the original input width and height into account. Fixed with commit b78d912.
This commit also deprecates the confusing
&a=focal-x%-y%percentage parameter, you can use&a=focal&fpx=[x decimal]&fpy=[y decimal]instead. The documentation has been updated to reflect this change:
https://images.weserv.nl/docs/crop.html#focal-pointThanks for reporting this!
@kleisauke Sounds good - I can't find any info about your deployment procedure? - I can see the documentation change is not live a least.
It's supposed to be live. There ought to be a pop-up when new content is available (i.e. when the service worker has installed an update), for example:
I have started to use your image service with focalpoint.
https://images.weserv.nl/docs/crop.html#focal-point
We have a focus point selector for images in the administration, but after comparing the focus point selector preview to the images scaling results, I figured out that your service does not take the percentage set, as a focus point to make the most optimale image from but as a percentage of the possible cut frames of the image matching the aspect ratio.
To me that is a stange way to handle this - why would it not be handled as a focus point which to me at least is the most logical way to implement it, though I understand that this maybe was a faster implementation..