Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c2408b86a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "ox": patch | |||
There was a problem hiding this comment.
Mark the new public API as a minor release
When Changesets versions this commit, patch will publish these additions as a bug-fix release even though the commit adds new public subpath exports and new requireFunds/fundingPolicy API fields. This is an additive feature and should use a minor changeset so consumers can rely on patch releases not expanding the public API.
Useful? React with 👍 / 👎.
| if (transaction.requireFunds) | ||
| transaction_.requireFunds = transaction.requireFunds.map( | ||
| FundingRequirement.fromRpc, | ||
| ) |
There was a problem hiding this comment.
Normalize null funding lists in transaction responses
When the Tempo node serializes an absent optional requireFunds field as null, this falsy branch skips conversion, but ox_Transaction.fromRpc has already copied the raw field via object spread. Because requireFunds was not added to the optional-null scrub list below, Transaction.fromRpc returns requireFunds: null despite the domain type allowing only an array or undefined; the Zod transaction codec has the same omission in nullableFields and rejects such a response outright.
Useful? React with 👍 / 👎.
| /** Effective gas price paid by the sender in wei. */ | ||
| gasPrice?: bigintType | undefined | ||
| /** Key authorization for provisioning a new access key. */ | ||
| /** Required balances before application calls. */ |
There was a problem hiding this comment.
Restore TSDoc for keyAuthorization
Adding requireFunds between the existing key-authorization comment and the keyAuthorization property leaves that public property without attached TSDoc, so its description disappears from generated API documentation. Move the existing comment back immediately above keyAuthorization while keeping the new funding comment with requireFunds.
AGENTS.md reference: AGENTS.md:L65-L65
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99c0b75af9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ...(authorization.fundingPolicy !== undefined | ||
| ? { fundingPolicy: FundingPolicy.fromRpc(authorization.fundingPolicy) } | ||
| : {}), |
There was a problem hiding this comment.
Treat null funding policies as absent
When the node returns a key authorization without a funding policy as fundingPolicy: null, this condition treats the field as present and passes null to FundingPolicy.fromRpc, which eventually dereferences admins and throws. The neighboring optional RPC fields already normalize the node's null representation with ?? undefined; fundingPolicy should do the same, and the Zod RPC schema should accept null as well.
Useful? React with 👍 / 👎.
| if (auth.fundingPolicy !== undefined) | ||
| FundingPolicy.toTuple(auth.fundingPolicy) |
There was a problem hiding this comment.
Add funding-policy failures to public error unions
For invalid policy IDs or inline rules, this newly added call can throw FundingPolicy.InvalidPolicyError, but from.ErrorType still lists only the preexisting signature/account errors. The same omission affects the other conversion paths that now invoke FundingPolicy; include the funding-policy failure in their exported ErrorType unions so consumers do not receive incomplete public error typing.
AGENTS.md reference: AGENTS.md:L78-L78
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45c2c9d10b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * }) | ||
| * ``` | ||
| */ | ||
| export function assert(value: FundingRequirement): void { |
There was a problem hiding this comment.
Publish error unions for the funding codecs
This new public module's throwing exports (assert, from, toTuple, fromTuple, fromRpc, and toRpc) have no matching function namespaces containing ErrorType, so consumers cannot derive their possible failures using the standard Ox API pattern. Add per-function error unions, including InvalidRequirementError and delegated address/hex errors; the other new funding codec modules need the same treatment.
AGENTS.md reference: AGENTS.md:L74-L78
Useful? React with 👍 / 👎.
Added TIP-1120 funding transactions, committed policy rules, and access key policy authorization, with native DEX payload codecs and backward-compatible encoding.
Implements tempoxyz/tempo#7678.