Repository navigation
fix(0.x): decode __proto__ map keys as own properties in Cbor.decode - #581
Merged
Merged
Conversation
Backport of #573 from main. Amp-Thread-ID: https://ampcode.com/threads/T-01a1bc8e-b9c6-72b0-974a-535c6c1ee1a6 Co-authored-by: jxom <jake@tempo.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Published pnpm add ox@pr-581
pnpm add ox@0.0.0-pr-581-4692639 |
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #573 from
mainto0.x, so the0.14.xline gets it.Cbor.decodebuilt maps withresult[key] = value, so a__proto__key went through theObject.prototype.__proto__setter. An object ornullvalue replaced the decoded object's prototype, and any other value was dropped. The decoder now defines__proto__as an own enumerable property, asJSON.parsedoes, for both definite and indefinite-length maps.Differences from
main: none in the source. The new test is formatted with Biome, which0.xuses.Local checks
vitest --project coreonCbor,CoseKeyandwebauthn: 265 tests passedpnpm check:types: passedbiome checkon the changed files: passedOriginal author: @RaphaelFakhri. Fixes #572 on
0.x.