fix: improve SHT_SYMTAB_SHNDX handling - #1846
Merged
Merged
Conversation
- add SymbolSection to fix conflated meaning of the shndx parameter to define_symbol. Previously a section index of 0xfff1 or 0xfff2 would be encoded in st_shndx as SHN_ABS or SHN_COMMON instead of SHN_XINDEX - check against SHN_LORESERVE instead of using try_into in a few places - a couple of other minor fixes
davidlattimore
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue I noted in #1783 (comment) plus some related issues. I noticed these while doing newtype changes for #1831.
The
From<u16>impl forSymbolSectionis slightly error prone, but significantly more concise for calls, and I expect it to change toFrom<object::elf::ShdrIndex>in future.The mold tests for this still pass.