feat: implement --emit-relocs - #2461
Draft
vishruth-thimmaiah wants to merge 4 commits into
Draft
vishruth-thimmaiah wants to merge 4 commits into
vishruth-thimmaiah wants to merge 4 commits into
Conversation
Signed-off-by: Vishruth Thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: Vishruth Thimmaiah <vishruththimmaiah@gmail.com>
vishruth-thimmaiah
marked this pull request as ready for review
August 28, 2026 13:55
davidlattimore
left a comment
Member
There was a problem hiding this comment.
Does this get offsets correct when riscv size-reducing relaxations occur? If not, it might be reasonable to error if the flag is enabled concurrently with size-reducing relaxations - unless there's an easy way to make them work.
| let old_flags = per_symbol_flags | ||
| .get_atomic(canonical) | ||
| .fetch_or(ValueFlags::SYMTAB_INSTALLED); | ||
| if !old_flags.contains(ValueFlags::SYMTAB_INSTALLED) { |
Member
There was a problem hiding this comment.
Is this deterministic? It looks like it might not be. I wonder if it might be simpler if you just set the flag on the canonical definition and made it responsible for writing the symtab entry.
Member
|
Another thought... do other linkers emit one relocation section per input section or one relocation section per output section? I'm unsure if it matters, but one per output section is likely to perform a whole lot better. |
vishruth-thimmaiah
marked this pull request as draft
September 6, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
--emit-relocs. This flag is used to retain all relocations from input files, similar to a partial object.