Add lightningcss and minify-js feature flags#247
Open
charlyisidore wants to merge 1 commit intowilsonzlin:masterfrom
Open
Add lightningcss and minify-js feature flags#247charlyisidore wants to merge 1 commit intowilsonzlin:masterfrom
lightningcss and minify-js feature flags#247charlyisidore wants to merge 1 commit intowilsonzlin:masterfrom
Conversation
|
In
|
b410661 to
f6f6b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
lightningcssandminify-jsfeature flags to theminify-htmlcrate.It allows significantly lighter and faster compilation for users who don't use the provided CSS/JS minifiers. It may also help solving dependency hell issues.
Changes:
minify-html/Cargo.toml, dependencieslightningcssandminify-jsare optional.lightningcssandminify-jsare enabled by default, therefore the current behavior is preserved.Cfg, fieldsminify_cssandminify_jsare behind feature flags.