Use a custom error rather than SyntaxError in Python wrapper - #283
Open
frankier wants to merge 1 commit into
Open
Use a custom error rather than SyntaxError in Python wrapper#283frankier wants to merge 1 commit into
frankier wants to merge 1 commit into
Conversation
SyntaxError is for Python syntax errors and uses custom formatting relying on certain slots being set. This results in the error not being printed in some cases. This commit creates MinifyError which is thrown instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyntaxError is for Python syntax errors and uses custom formatting relying on certain slots being set. This results in the error not being printed in some cases. This commit creates MinifyError which is thrown instead.
By the way, here's where
SyntaxErroris custom cased in CPython: https://github.com/python/cpython/blob/2ffab083782968a4d732738f4f1dff6bbd69d2b0/Lib/traceback.py#L1532-L1623