Fix concurrent scenario mapping removal - #3596
Open
GtechGovind wants to merge 1 commit into
Open
GtechGovind wants to merge 1 commit into
GtechGovind wants to merge 1 commit into
Conversation
GtechGovind
marked this pull request as ready for review
September 20, 2026 05:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent scenario mutations currently perform separate read/modify/write operations. When two stubs from the same scenario are removed concurrently, both removals can read the same original scenario and write stale replacements, leaving one removed mapping behind.
This change serializes the scenario mutation entry points while keeping read-only operations lock-free. It also adds a deterministic regression test that coordinates two concurrent removals and verifies that the scenario is deleted after its final mappings are removed.
References
Testing
./gradlew :test --tests com.github.tomakehurst.wiremock.stubbing.ScenariosTest./gradlew spotlessCheck :test --tests com.github.tomakehurst.wiremock.stubbing.ScenariosTest./gradlew checkgit diff --checkSubmitter checklist
#help-contributingor a project-specific channel like#wiremock-java