Fix equalToXml matching with NamespaceAwareness.NONE - #3511
Open
DragonFSKY wants to merge 1 commit into
Open
DragonFSKY wants to merge 1 commit into
DragonFSKY wants to merge 1 commit into
Conversation
DragonFSKY
force-pushed
the
fix/xml-namespace-awareness-none
branch
from
July 22, 2026 04:00
f3000cd to
2dfe38e
Compare
DragonFSKY
marked this pull request as ready for review
July 22, 2026 04:33
Use the full DOM node name when localName is unavailable so the order-invariant matcher can sort namespace-unaware elements. Add regression coverage for both comparator branches under NamespaceAwareness.NONE.
DragonFSKY
force-pushed
the
fix/xml-namespace-awareness-none
branch
from
August 25, 2026 12:24
2dfe38e to
f3b5f5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
NamespaceAwareness.NONE, DOM nodes have no local name. The order-invariant matcher sorted sibling elements byNode#getLocalName(), which caused comparison to fail as soon as two siblings were sorted.Use the full node name only when the local name is unavailable. This preserves the existing namespace-aware behavior and gives namespace-unaware elements the name used by their comparison mode.
Fixes #3508
Verification
masterand pass with this change../gradlew testspotlessJavaCheck