Skip to content

Added social icon for Nostr #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2024
Merged

Added social icon for Nostr #2579

merged 3 commits into from
Nov 8, 2024

Conversation

@RafidMuhymin
Copy link
Member

@RafidMuhymin RafidMuhymin commented Nov 6, 2024 •
edited
Loading

Description

  • Added social icon for Nostr.

Icon Reference: https://github.com/mbarulli/nostr-logo/blob/main/SVG/nostr-icon-purple-on-white.svg. I optimized the icon and made changes to align with the other social icons.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 73edf15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 6, 2024
@netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 73edf15
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/672d96f8a590e20008e65fa8
😎 Deploy Preview https://deploy-preview-2579--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 6, 2024

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

delucis
delucis reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @RafidMuhymin (and nice to see you 👋)!

Left two tiny superficial suggestions, but this all looks solid to me 🚀

@delucis delucis added the 🌟 patch Change that triggers a patch release label Nov 6, 2024
@delucis delucis mentioned this pull request Nov 7, 2024
Closed
RafidMuhymin and others added 2 commits November 8, 2024 10:43
@RafidMuhymin @delucis
further optimized svg
1ea0e44 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@RafidMuhymin @delucis
updated changeset
73edf15 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@RafidMuhymin
Copy link
Member Author

RafidMuhymin commented Nov 8, 2024

Hi 👋 @delucis ! Thanks for the suggestions, I have committed them. And nice to see you too!

delucis
delucis approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @RafidMuhymin! 🎉

@delucis delucis merged commit 241966b into withastro:main Nov 8, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 11, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-inject-translations
8f0acd8 
* main: (27 commits)
  i18n(ko-KR): update `site-search.mdx`
  [ci] release (withastro#2590)
  Support passing more options to the DocSearch component (withastro#2589)
  [ci] release (withastro#2587)
  Add changeset for withastro#2252 (withastro#2588)
  [ci] format
  Update dev dependencies (withastro#2582)
  Build performance optimizations for projects with large sidebars (withastro#2252)
  Fix a11y CI workflow (withastro#2503)
  Update `astro-expressive-code` to v0.38 (withastro#2551)
  Added social icon for Nostr (withastro#2579)
  [ci] format
  docs(showcase): add docs.reactbricks.com to showcase (withastro#2586)
  i18n(ja): Update site-search.mdx (withastro#2577)
  i18n(ja): Update pages.mdx (withastro#2576)
  i18n(fr): Update `reference/plugins.mdx` from withastro#2549 (withastro#2574)
  [ci] format
  docs: update showcase-sites.astro (withastro#2562)
  Throw an error if a showcase image does not have the required dimensions (withastro#2573)
  i18n(ja): Update frontmatter.md (withastro#2566)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@RafidMuhymin @delucis
Added social icon for Nostr (withastro#2579)
695ed09 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafidMuhymin @astrobot-houston @delucis