Skip to content

Update dev dependencies #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 8, 2024
Merged

Update dev dependencies #2582

merged 18 commits into from
Nov 8, 2024

Conversation

@delucis
Copy link
Member

@delucis delucis commented Nov 6, 2024 •
edited
Loading

Description

  • Updates development versions of Astro and other dependencies
  • Should finally fix Astro’s Ecosystem CI which has been failing for a while now
  • Two non-dependency changes:
    • Due to a type (non)issue in the docs Astro config, I cast the type of the Markdoc grammar to any for now. We can solve upstream in Expressive Code later.
    • Looks like the upgraded Tailwind version changed order of some of its generated code, but looks like a correct bug fix to me of ensuring user CSS is generated after Tailwind boilerplate instead of before.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cea3452

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package labels Nov 6, 2024
@netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit cea3452
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/672e39dc55d2970008d2b1a8
😎 Deploy Preview https://deploy-preview-2582--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
/index.html 6.15 KB (-0.07% 🔽)
/_astro/*.js 22.41 KB (+0.21% 🔺)
/_astro/*.css 13.73 KB (0%)

@github-actions github-actions bot added the 🌟 tailwind Changes to Starlight’s Tailwind package label Nov 6, 2024
HiDeoo
HiDeoo approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect to me, even locally 👍

@delucis delucis merged commit bd91703 into main Nov 8, 2024
16 checks passed
@delucis delucis deleted the chris/update-deps branch November 8, 2024 16:23
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 11, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-inject-translations
8f0acd8 
* main: (27 commits)
  i18n(ko-KR): update `site-search.mdx`
  [ci] release (withastro#2590)
  Support passing more options to the DocSearch component (withastro#2589)
  [ci] release (withastro#2587)
  Add changeset for withastro#2252 (withastro#2588)
  [ci] format
  Update dev dependencies (withastro#2582)
  Build performance optimizations for projects with large sidebars (withastro#2252)
  Fix a11y CI workflow (withastro#2503)
  Update `astro-expressive-code` to v0.38 (withastro#2551)
  Added social icon for Nostr (withastro#2579)
  [ci] format
  docs(showcase): add docs.reactbricks.com to showcase (withastro#2586)
  i18n(ja): Update site-search.mdx (withastro#2577)
  i18n(ja): Update pages.mdx (withastro#2576)
  i18n(fr): Update `reference/plugins.mdx` from withastro#2549 (withastro#2574)
  [ci] format
  docs: update showcase-sites.astro (withastro#2562)
  Throw an error if a showcase image does not have the required dimensions (withastro#2573)
  i18n(ja): Update frontmatter.md (withastro#2566)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@delucis
Update dev dependencies (withastro#2582)
5827244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 markdoc Changes to Starlight’s Markdoc package 🌟 tailwind Changes to Starlight’s Tailwind package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delucis @astrobot-houston @HiDeoo