Skip to content

fix(desktop): pass config dir to MCP clients - #2302

Merged
lazybean merged 1 commit into
mainfrom
desktop-fix-mcp
Sep 4, 2026
Merged

lazybean merged 1 commit into
mainfrom
desktop-fix-mcp

Conversation

@lazybean

@lazybean lazybean commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pass Desktop's Coral config directory into MCP client installs via CORAL_CONFIG_DIR.
  • Share Desktop runtime config-dir selection between the sidecar and MCP config writer.
  • Add regression coverage for new installs, existing env-aware installs, and old env-less installs being updateable.

Validation

  • npm run check --prefix apps/desktop
  • npm test --prefix apps/desktop

lazybean commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lazybean
lazybean marked this pull request as ready for review September 3, 2026 14:28

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/desktop/src/main/mcp-config.ts
Comment thread apps/desktop/src/main/mcp-config.test.ts Outdated

lazybean commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Sep 4, 9:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 4, 9:44 AM UTC: @lazybean merged this pull request with Graphite.

@lazybean
lazybean merged commit 2cba360 into main Sep 4, 2026
22 checks passed
@lazybean
lazybean deleted the desktop-fix-mcp branch September 4, 2026 09:44
lazybean pushed a commit that referenced this pull request Sep 4, 2026
🤖 I have created a release *beep* *boop*
---


## [0.15.4](v0.15.3...v0.15.4) (2026-09-04)


### Bug Fixes

* **coral-ui:** report a failed trace read inside the detail panel ([#2300](#2300)) ([9dfe407](9dfe407))
* **desktop:** pass config dir to MCP clients ([#2302](#2302)) ([2cba360](2cba360))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants