Conversation
wkentaro
commented
Oct 15, 2025
Owner
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to keep previous brightness and contrast settings together, consolidating two separate configuration options into a single unified setting.
- Replaces separate
keep_prev_brightnessandkeep_prev_contrastconfig options with a combinedkeep_prev_brightness_contrastoption - Adds migration logic to handle existing config files with the old settings
- Updates the UI to include a toggle for the new combined setting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| labelme/config/default_config.yaml | Consolidates two brightness/contrast config options into one |
| labelme/config/init.py | Adds migration function to handle old config settings |
| labelme/app.py | Updates UI and logic to use the new combined setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wkentaro
deleted the
feat_app_add_option_to_keep_previous_brightness_contrast_settings
branch
October 15, 2025 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.