Skip to content

feat: mark preview features with a BETA badge in settings - #2275

Merged
wkentaro merged 1 commit into
mainfrom
feat/settings-beta-badge
Jul 1, 2026
Merged

feat: mark preview features with a BETA badge in settings#2275
wkentaro merged 1 commit into
mainfrom
feat/settings-beta-badge

Conversation

@wkentaro

@wkentaro wkentaro commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds a beta flag to Setting and renders a small "BETA" badge beside flagged features in the Settings dialog, signaling they are shipped for early use so users expect rough edges and report issues.
  • Flags two features as beta: "Show shape labels on canvas" (feat: add shape.show_labels option to draw labels on the canvas #2182) and "Allow points outside the image boundary" (feat: allow annotation points outside the image boundary #2223).
  • The badge is a muted outlined pill drawn from palette roles (palette(text) / palette(mid)), so it tracks light/dark theme switches via the existing _retheme path and reads as a status tag rather than an interactive control.

Test plan

  • test_beta_settings_render_a_badge asserts a badge renders for exactly the schema's beta=True settings
  • uv run pytest tests/unit/widgets/settings_dialog_test.py tests/unit/_config/_schema_test.py tests/e2e/settings_test.py — 38 passed
  • ruff + ty clean
  • Rendered the dialog offscreen in light and dark to confirm the badge adapts and stays legible in both

@wkentaro wkentaro self-assigned this Jul 1, 2026
@wkentaro
feat: mark preview features with a BETA badge in settings
804de63 
Add a `beta` flag to Setting and render a theme-adaptive BETA badge beside the
features shipped for early use (Show shape labels on canvas, Allow points
outside the image boundary) so users know to expect rough edges and report
issues. The badge draws from palette roles so it tracks light/dark theme
switches and reads as a status tag rather than an interactive control.
@wkentaro
wkentaro force-pushed the feat/settings-beta-badge branch from 8112f50 to 804de63 Compare July 1, 2026 10:19
@wkentaro wkentaro added this to the v7.0.0 milestone Jul 1, 2026
@wkentaro

wkentaro commented Jul 1, 2026

Copy link
Copy Markdown
Owner Author

This was generated by AI during PR processing.

Verdict: recommend-merge

Finalized this tick:

  • Rebase: not needed. main advanced 2 commits (the fix: keep annotation label text visible on styles that collapse the text sub-rect #2273 merge). The only overlap with this PR is CHANGELOG.md — and it's inert: this PR's entry lands in ### Added while fix: keep annotation label text visible on styles that collapse the text sub-rect #2273's is in ### Fixed, so the merge is a clean auto-merge (GitHub reports CLEAN) and no test executes the changelog. The code files main touched (label_list_widget.py) are disjoint from this PR's code, so the green CI still reflects the merged code result. (The fix: keep annotation label text visible on styles that collapse the text sub-rect #2273 lines showing as deletions in the raw diff are just diff direction — this branch predates that merge.)
  • Review gate: /code-review (medium) found no meaningful issues. Verified the one subtle point: _build_beta_badge styles via palette(text)/palette(mid) stylesheet refs, and _app._retheme re-applies every palette(-containing stylesheet on colorSchemeChanged, so the badge re-resolves on a live theme switch (consistent with the app's theming architecture — no faded-badge bug). The beta schema field defaults False and only annotates existing settings; _build_label_cell cleanly wraps label + badge.
  • History: single, well-formed commit — nothing to reshape.
  • Tests: the new test_beta_settings_render_a_badge asserts each beta=True setting renders a badge beside the right label; all 12 settings-dialog tests pass locally.
  • CI: all 8 test matrix jobs + lint green. No push this tick, so the existing checks are authoritative.

Ready for maintainer merge.

@wkentaro wkentaro added the recommend-merge pr: Agent finalized and endorses it: review and merge label Jul 1, 2026
@wkentaro
wkentaro merged commit c3c6913 into main Jul 1, 2026
8 checks passed
@wkentaro
wkentaro deleted the feat/settings-beta-badge branch July 1, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wkentaro wkentaro

Labels

recommend-merge pr: Agent finalized and endorses it: review and merge

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@wkentaro