fix(automation): round AI mask bounding boxes - #2464
Merged
Merged
Conversation
wkentaro
force-pushed
the
fix/2336-mask-bbox-rounding
branch
from
August 7, 2026 09:49
9ce4d79 to
d9bc061
Compare
The Mask Shape builder truncated fractional bbox coordinates while suppression derived Mask extents by rounding. Round the stored points to keep placement and Existing Shape Suppression consistent.
wkentaro
force-pushed
the
fix/2336-mask-bbox-rounding
branch
from
August 7, 2026 09:51
d9bc061 to
226176f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2336.
_shape_from_detectiontruncated the mask bbox withint()while Existing Shape Suppression rounds the same bbox, so AI mask shapes drifted up to 1px and a fractional-bbox mask fed back as an existing shape raisedValueError. The bbox now usesint(round(...)), matching the suppression contract.Test plan
make lintandmake test(1165 passed)