fix: support noxfile being a symlink - #829
Merged
Merged
Conversation
henryiii
marked this pull request as draft
May 19, 2024 04:11
henryiii
commented
May 19, 2024
|
I actually use the existing behavior (see #828 (comment)) but I can probably work around a change if this is more natural. I'll follow this so I know if this comes in and breaks me. |
This was referenced Oct 7, 2024
Closed
henryiii
force-pushed
the
henryiii/fix/symlinknox
branch
from
October 18, 2024 07:46
27302d5 to
4a5a190
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/symlinknox
branch
2 times, most recently
from
November 1, 2024 22:33
82c6152 to
41dde93
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/symlinknox
branch
from
November 1, 2024 22:42
41dde93 to
b4aa701
Compare
henryiii
marked this pull request as ready for review
November 1, 2024 23:33
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Collaborator
Author
|
Going to get it in for the next version; as seen in the tests, you can work around the change if you need the old behavior using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #828.
If you need the non-symlinked file, it's easy to get with
__file__, as can be seen in the tests.