Repository navigation
Fix fatal when default_locale is empty - #142
Merged
coreymckrill merged 1 commit intoAug 2, 2024
Merged
Conversation
coreymckrill
approved these changes
Aug 2, 2024
coreymckrill
left a comment
Contributor
There was a problem hiding this comment.
@msaggiorato thanks for the PR! Wow, you were indeed lucky to encounter this error. Tested and confirmed that this fixes the issue.
Contributor
|
Opened a separate issue to fix the default_locale value for MV: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes a fatal error when trying to generate orders. Some countries may have an empty "default_locale" property. In which case, this would throw a fatal (at least in PHP 8).
There's actually, only one case of this here, so I guess I was "lucky" to hit this. This issue should be fixed separately in Woo itself, but checking here to avoid a fatal wouldn't be bad either IMO.
How to test the changes in this Pull Request:
wp eval "var_dump( WC\SmoothGenerator\Generator\CustomerInfo::generate_person('MV') );"wp eval "var_dump( WC\SmoothGenerator\Generator\CustomerInfo::generate_person('MV') );"Other information:
Changelog entry
FOR PR REVIEWER ONLY: