Repository navigation
Fix touch panning when drag selection is enabled - #5918
Merged
peterkogo merged 2 commits intoAug 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e0f2956 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Just to clarify, I am seeing panning + selection behavior only when zooming via multi-touch with None the less, fix is correct! Thank you for the contribution :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panOnDragbutton arrays restrict mouse input, not touch inputWhy
When
selectionOnDragis enabled andpanOnDragis a mouse-button array such as[1, 2], a primary touch currently starts both viewport panning and a marquee selection. The system filter intentionally treats button arrays as mouse-only for touch panning (see #4229), so the Pane should not capture the same touch as a selection unless the selection key is explicitly active.This uses the gesture's actual
pointerType, so hybrid touchscreen computers keep normal mouse and pen behavior.Behavior
panOnDrag+ no selection key: pan without marqueepanOnDrag: marquee selectionpanOnDrag={false}and pen behavior remain unchangedTests
Related to #2709.