Repository navigation
fix(react): correct offset math in Background pattern - #5938
Merged
Merged
Conversation
The scaledOffset calculation used an errant "|| 1" fallback (likely
copy-pasted from the scaledGap line above, where it makes sense to
floor a zero gap). Applied to offset this caused two bugs:
- With the default offset={0}, offset*zoom is 0/falsy, so the
fallback kicked in and added an extra +1px on top of the intended
half-cell centering (translate(-11,-11) instead of (-10,-10) for
gap={20}, zoom=1).
- With any non-zero offset, offset*zoom is truthy, so the "||" short-
circuits and the entire "+ patternDimensions/2" centering term is
dropped, not just miscalculated (e.g. gap={100}, offset={2} produced
translate(-2,-2) instead of the correct (-52,-52)).
Removing the fallback and just adding the two terms fixes both cases.
🦋 Changeset detectedLatest commit: a0f668f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Thanks for uconvering this @Feyyus, looks good to me! 💕 |
Correct miscalculation of the pattern offset in <Background /> due to an incorrect fallback in the offset math, which caused alignment issues.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaledOffset calculation used an errant "|| 1" fallback (likely copy-pasted from the scaledGap line above, where it makes sense to floor a zero gap). Applied to offset this caused two bugs:
Removing the fallback and just adding the two terms fixes both cases.