Conversation
🦋 Changeset detectedLatest commit: a797639 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jundejz
marked this pull request as ready for review
August 25, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measuring the height and width of a node right after a change in height or width resulted in a stale measurement since there's a non-deterministic delay in
rAF. We makesuseUpdateNodeInternalsasync to ensure a fixed delay. In React we wrap therAFin aPromiseand in Svelte we usetick().then(...)Changes Made
useUpdateNodeInternalswrap therAFin aPromisetick().then(...)try...catchTesting
UpdateNodeInternalsNodetest fixture component andupdateNodeInternalstest addedN.B. I'm unsure about the Vue change since I've been working on my fork on
main- happy for you to do any changes in this regardCloses #3910