fix: add missing package subpath entrypoints - #72
Open
itosa-kazu wants to merge 1 commit into
Open
itosa-kazu wants to merge 1 commit into
itosa-kazu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core,memory, andpoliciessource entrypoints that are already declared as package subpath exports.jsrelative imports in the new ESM entrypoints and memory provider import chain so the packed package can load in Node ESM consumersWhy
The published package advertises these subpaths:
@juspay-jaf/jaf/core@juspay-jaf/jaf/memory@juspay-jaf/jaf/policiesbut
@juspay-jaf/jaf@0.1.46does not shipdist/core/index.js,dist/memory/index.js, ordist/policies/index.js, so clean consumer imports fail withERR_MODULE_NOT_FOUND.Validation
corepack pnpm run buildcorepack pnpm run typecheckcorepack pnpm run lintgit diff --checknpm pack --pack-destination ... --json --ignore-scriptsimport('@juspay-jaf/jaf/core')import('@juspay-jaf/jaf/memory')import('@juspay-jaf/jaf/policies')I also reproduced the current published-package failure in a clean temp consumer before this patch.