fix(api): register missing HTTP verbs on several ES-compat endpoints - #8
Merged
Merged
Conversation
Several endpoints only registered one HTTP verb where real Elasticsearch accepts more than one, causing 405s for clients that use the other verb: - _refresh, _analyze (index-scoped + global), _msearch: only POST, real ES also accepts GET - _clone, _shrink, _split (the resize-index family): only POST, real ES also accepts PUT Concretely this blocks Kibana's saved-object migration, which issues PUT .../_clone/... during startup and gets a 405 today, causing a fatal migration error before Kibana renders anything. Fix: chain the missing verb onto the existing MethodRouter for each route in build_es_compat_router (router.rs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several ES-compat endpoints only register one HTTP verb where real Elasticsearch accepts more than one, causing 405s for clients that use the other verb:
_refresh,_analyze(index-scoped + global),_msearch: only POST, real ES also accepts GET_clone,_shrink,_split(the resize-index family): only POST, real ES also accepts PUTConcrete impact: this blocks Kibana's saved-object migration, which issues
PUT .../_clone/...during startup and gets a 405 today — a fatal migration error before Kibana renders anything. Repro'd against a local Kibana 8.13 instance.Fix: chain the missing verb onto the existing
MethodRouterfor each affected route inbuild_es_compat_router(router.rs). No behavior change for the already-working verb; purely additive.Tested:
cargo build --release -p xerj-apiclean, verified via curl thatPUT .../_clone/...now returns 200 instead of 405.