128tx exploit #1

Activity

1. xmrig commented on Apr 21, 2017

   

   xmrig

   on Apr 21, 2017

   Owner

   More actions

   Ok the task looks easy, add variable length support for blob (76+). It's right?

   One moment unclear, what is the upper limit? 128 or more? in xmr-stak-cpu code I see 112. It's little bit confusing. Thank you.
2. fireice-uk commented on Apr 21, 2017

   

   fireice-uk

   on Apr 21, 2017

   More actions

   The maximum length is 75 fixed + 9 variable so 84. I have a habit of rounding the sizeof manually sometimes.
3. xmrig commented on Apr 22, 2017

   

   xmrig

   on Apr 22, 2017

   Owner

   More actions

   @fireice-uk

   piNonce = (uint32_t*)(oWork.bWorkBlob + 39);
   

   It's ok? looks like another magic number.
4. fireice-uk commented on Apr 23, 2017

   

   fireice-uk

   on Apr 23, 2017

   More actions

   This is the nonce position in the miner's blob. The variable length fields that are included there are major_version, minor_version and timestamp. None of them are under control of the end user enough to make stuff fall out of place (section 4.1 here https://cryptonote.org/cns/cns003.txt )

   If you want to avoid magic numbers completely then you can parse the whole thing ( see section 1.2 here for a public domain parsing code https://tukaani.org/xz/xz-file-format.txt ).
5. smoresmores commented on Aug 31, 2017

   

   smoresmores

   on Aug 31, 2017

   More actions

   Is this issue solved? @xmrig
6. xmrig commented on Aug 31, 2017

   

   xmrig

   on Aug 31, 2017

   Owner

   More actions

   Probably yes, at least three no overflows now, but I not 100% sure it works as expected.
7. xmrig

   added a commit that references this issue on Feb 17, 2018

   Merge pull request #1 from xmrig/master

   ...

   41b9274
8. xmrig

   closed this as completedon Nov 5, 2018
9. SChernykh

   added a commit that references this issue on Dec 3, 2021

   Updated GhostRider documentation

   ...

   454f97f
10. rfiyoy

    added a commit that references this issue on Jan 20, 2022

    Delete package.json

    ...

    41ac9f9