Conversation
src/base/net/tls/TlsGen.cpp: In member function 'bool
xmrig::TlsGen::generate_x509(const char*)':
src/base/net/tls/TlsGen.cpp:118:32: error: invalid conversion from
'const X509_name_st*' to 'X509_NAME*' {aka 'X509_name_st*'}
[-fpermissive]
118 | X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0);
| ^~~~
| |
| const X509_name_st*
openssl/openssl#29117
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
SChernykh
approved these changes
May 2, 2026
|
@bkuhls instead of casting away the const have you considered using |
Contributor
|
The better fix (compared to what znc did) would be |
SChernykh
suggested changes
Jul 24, 2026
SChernykh
left a comment
Contributor
There was a problem hiding this comment.
The better fix:
auto name = X509_NAME_dup(X509_get_subject_name(cert));
X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0);
X509_set_issuer_name(m_x509, name);
X509_NAME_free(name);
--- a/src/base/net/tls/TlsGen.cpp
+++ b/src/base/net/tls/TlsGen.cpp
@@ -114,10 +114,11 @@ bool xmrig::TlsGen::generate_x509(const char *commonName)
X509_gmtime_adj(X509_get_notBefore(m_x509), 0);
X509_gmtime_adj(X509_get_notAfter(m_x509), 315360000L);
- auto name = X509_get_subject_name(m_x509);
+ auto name = X509_NAME_dup(X509_get_subject_name(cert));
X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0);
X509_set_issuer_name(m_x509, name);
+ X509_NAME_free(name);
return X509_sign(m_x509, m_pkey, EVP_sha256());
}Produces: |
|
Did you mean: --- a/src/base/net/tls/TlsGen.cpp
+++ b/src/base/net/tls/TlsGen.cpp
@@ -114,10 +114,11 @@ bool xmrig::TlsGen::generate_x509(const char *commonName)
X509_gmtime_adj(X509_get_notBefore(m_x509), 0);
X509_gmtime_adj(X509_get_notAfter(m_x509), 315360000L);
- auto name = X509_get_subject_name(m_x509);
+ auto name = X509_NAME_dup(X509_get_subject_name(m_x509));
X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0);
X509_set_issuer_name(m_x509, name);
+ X509_NAME_free(name);
return X509_sign(m_x509, m_pkey, EVP_sha256());
} |
Contributor
|
Yes, it's |
rroessler
suggested changes
Aug 18, 2026
Comment on lines
117
to
121
| auto name = X509_get_subject_name(m_x509); | ||
| X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0); | ||
| X509_NAME_add_entry_by_txt((X509_NAME *) name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0); | ||
|
|
||
| X509_set_issuer_name(m_x509, name); | ||
|
|
There was a problem hiding this comment.
The recommended fix is to allocate a new X509_NAME then to assign it to both the subject and issuer of the certificate (since duplication does not use the original subject name):
auto name = X509_NAME_new();
X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, reinterpret_cast<const uint8_t *>(commonName), -1, -1, 0);
X509_set_subject_name(m_x509, name);
X509_set_issuer_name(m_x509, name);
X509_NAME_free(name);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssl/openssl#29117