Skip to content

Fix slow CSS selector - #1115

Merged
j0k3r merged 2 commits into
masterfrom
css-lint-fix
Jun 6, 2016
Merged

j0k3r merged 2 commits into
masterfrom
css-lint-fix

Conversation

@nmielnik

@nmielnik nmielnik commented Jun 6, 2016

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
New tests added? updated
License MIT

Description

Fixed a slow CSS selector that our linter was complaining about:

Linting dist/css/medium-editor.css...ERROR
[L209:C1]
WARNING: Unqualified attribute selectors are known to be slow. Unqualified attribute selectors are known to be slow. (unqualified-attributes) Browsers: All

To fix this, we can add a medium-editor-element class to the editor element, and update the CSS selector to use that instead of an unqualified attribute selector.

@j0k3r

j0k3r commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

I'm ok with that 👍

@j0k3r
j0k3r merged commit a8d2932 into master Jun 6, 2016
@j0k3r
j0k3r deleted the css-lint-fix branch June 6, 2016 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants