nikon_he: complete HE/HE* header parsing and integration - #1
Merged
Merged
Conversation
Owner
|
Nice work! |
|
Nikon ZR works |
|
Nikon Z5ii RAWs also works! |
|
I've been putting together a public format reference for Nikon HE/HE* and tested the implementation at
With the corrections, the decoder matches Adobe's raw samples exactly across the 11 natural HE/HE* files tested from Z9, Z8, Z6III, Zf and Z5II bodies. The comments include the changes and validation details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on LibRaw#826 by @yogthos. The original three commits and authorship are preserved; this PR contains only the follow-up changes.
Changes:
Validation:
git apply --checkagainst Add Nikon Z9 High-Efficiency (HE) RAW format support LibRaw/LibRaw#826 head8aebd05Known limits:
AI assistance was used during implementation and review. I reviewed and tested the resulting code and take responsibility for the contribution.
I agree that this contribution may be distributed under both LGPL 2.1 and CDDL 1.0.