test(import): cover single-file import, document precedence#33
Merged
Conversation
PR #30 added single-file import (import = 'plugins.foo' resolving lua/plugins/foo.lua) but landed without tests or docs. This adds: - tests for the single-file path, file-over-directory precedence, and enabled=false gating on a single-file import - a code comment making the file-shadows-directory precedence intentional - vimdoc (doc/zpack.txt) coverage of the single-file form and precedence - README + docs/spec.md coverage of the file-over-directory precedence - guaranteed restoration of mocked vim.fn.stdpath / vim.uv.fs_stat in the test harness teardown, so an assertion failure mid-test no longer leaks the mock into later tests Closes zpack_nvim-thi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30, which added single-file import (
import = 'plugins.foo'resolvinglua/plugins/foo.lua, lazy.nvim parity) but landed without tests or docs.Changes
tests/import_test.lua): single-file resolution (and that it does not walk a same-named directory), file-over-directory precedence, andenabled = falsegating on a single-file import.tests/helpers.lua): capturesvim.fn.stdpath/vim.uv.fs_statat setup and restores them inafter_each, so an assertion failure mid-test no longer leaks the mock into later tests (vim.uv == vim.loop).lua/zpack/import.lua): makes the file-shadows-directory precedence intentional, mirroring Lua's ownrequire(foo.luashadowsfoo/init.lua).doc/zpack.txt): documents the single-file form and the precedence rule in both the importing-specs section and theSpec.importreference.README.md/docs/spec.md: corrected the inlineimportcomments to reflect single-file resolution.Tradeoffs (recorded, not changed)
import = 'plugins'andimport = 'plugins.foo'requiresfoo.luatwice under different keys — harmless (require cache + merge dedup).Verification
nvim -u NONE -l tests/busted.lua— 483 passed / 0 failedluacheck lua/ tests/— 0 warnings / 0 errors