test(toolchain): muscle-memory drop-in rustup passthrough tests (#331) - #504
Merged
Merged
Conversation
#331) Closes the "muscle-memory drop-in tests" gap called out in #331: - rustup component add injects --toolchain (parallel to target add) - rustup toolchain list is forwarded verbatim (top-level mgmt verb) - rustup --version is forwarded verbatim - rustup target add --toolchain=<value> equals-form preserves user explicit toolchain (verifies the existing equals-form guard) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the "muscle-memory drop-in tests" gap called out in #331. Adds 4 integration tests covering the rustup passthrough surface:
rustup component addinjects--toolchain(mirrors the existingtarget addtest path)rustup toolchain listis forwarded verbatim — top-level mgmt verbs do not inject the pinrustup --versionis forwarded verbatim — bare flags before any positional are unscopedrustup target add --toolchain=<value>equals-form preserves the user-supplied toolchain (verifies the existing equals-form guard inrustup_args_specify_toolchain)The remaining sub-bullets of #331 (per-plugin
--lockedsupport and the per-(host, target) cross-compile lane sketch) are already shipped:PluginSpec::Detailedexposes--lockedandtoolchain preparealready targets the channel-pinned toolchain for component/target installs. This PR fills in the coverage gap and closes #331 for the wave-4 meta (#503).Closes #331.
Refs #503.
Test plan
soldr cargo build -p soldr-cli --testssoldr cargo test -p soldr-cli --test cli_toolchain rustup_passthrough_— all 7 tests passsoldr cargo fmt -- crates/soldr-cli/tests/cli_toolchain.rs🤖 Generated with Claude Code