fix: deadlock with blocking panes - #5152
Merged
Merged
Conversation
imsnif
added a commit
that referenced
this pull request
May 12, 2026
* fix: deadlock with blocking panes * rustfmt * add pr (cherry picked from commit 24f2173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in 0.44.2 where if we would open a pane with
--blockingand then change-mode (among some other actions) the session would get stuck.This was happening because of a deadlock in the route.rs thread. I fixed it by removing some unnecessary state the thread was holding, thus freeing it from the need to lock the relevant entity (session_data) at all.
Fixes #5141