Repository navigation
Prevent Python lock refreshes from downgrading supported tools - #14417
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python lock refresh in #14415 silently replaces mitmproxy 12.2.3 with 0.14.0 so newer transitive packages can be selected. Unbounded direct requirements allowed this to count as a successful solve.
Set supported lower bounds for every direct Python dependency using the versions already in the working lock. Configure Renovate to advance those bounds, while pip-compile continues resolving transitive dependencies as a unit. Extend the real Renovate extraction test to require floors, check each locked direct version against its range, and reject the observed mitmproxy downgrade.
Validation: Gazelle, Renovate extraction regression, strict configuration validation, root BUILD lint, and Python manifest integrity passed. The local pip-compile consistency check resolved the supported versions; its only differences are the documented macOS-specific appnope and mitmproxy-macos packages versus the Linux lock. Keep the Linux artifact and verify its next refresh in hosted CI.
#14415 remains draft with automerge disabled until regenerated with these constraints and verified.