Switch StakingRequestProvider to Redux - #407
Conversation
|
✔️ Deploy Preview for wilderworld-app ready! 🔨 Explore the source changes: 1a00311 🔍 Inspect the deploy log: https://app.netlify.com/sites/wilderworld-app/deploys/622a7c140c30b900090b5ee7 😎 Browse the preview: https://deploy-preview-407--wilderworld-app.netlify.app |
domw30
left a comment
There was a problem hiding this comment.
Nice 👍 Approving with a couple of questions 😁
| @@ -0,0 +1,210 @@ | |||
| import { useMemo, useCallback } from 'react'; | |||
There was a problem hiding this comment.
Leave this for now as we can do this in it's own PR - We should extract the error text in the file to a global error constant file and replace with all instances in the codebase, I think we re-use them quite a bit.
| import { useStakingController } from 'lib/hooks/useStakingController'; | ||
| import { useStakingRedux } from 'store/staking/hooks'; | ||
|
|
||
| export type UseStakingReturn = { |
There was a problem hiding this comment.
just a curious question mate...what is the difference using type over interface for the function props? I ask as I've been instructed in previous projects to use interface
There was a problem hiding this comment.
@domw30 You are right. I sometimes forget it :(
| DOMAIN_REQUEST_AND_CONTENTS_1, | ||
| DOMAIN_REQUEST_AND_CONTENTS_2, | ||
| } from './staking.mockData'; | ||
|
|
| fulfilled: DomainRequestAndContents[]; | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
I could be wrong but the comment and type names below look like they have slight typos? is stacking supposed to be staking?
There was a problem hiding this comment.
Good call - This is typo
Associated Notion Card
1. Pull request checklist
2. PR type
3. What is the old behaviour?
4. What is the new behaviour?
5. Other information