Skip to content

fix: Change logic for hiding Your Bid in NFT View - #408

Merged
colbr merged 1 commit into
developfrom
fix/cancel-bid-tweaks
Mar 10, 2022
Merged

fix: Change logic for hiding Your Bid in NFT View#408
colbr merged 1 commit into
developfrom
fix/cancel-bid-tweaks

Conversation

@colbr

@colbr colbr commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

Associated Notion Card


1. Pull request checklist

  • Notion card has been moved to the Code Review column
  • Notion card has a link to this PR
  • A reviewer has been assigned to the Notion card

2. PR type

Bugfix

3. What is the old behaviour?

As outlined by @domw30 here
https://www.loom.com/share/e6b267d132674742a96ebdaadf61bd47

4. What is the new behaviour?

Remedies for @domw30's feedback. In short, the Your Bid section hides when expected.

@colbr colbr added the bug Something isn't working label Mar 10, 2022
@colbr colbr self-assigned this Mar 10, 2022
@colbr
colbr requested review from padala and stacy-hunt as code owners March 10, 2022 10:00
@netlify

netlify Bot commented Mar 10, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for wilderworld-app ready!

🔨 Explore the source changes: cadb78e

🔍 Inspect the deploy log: https://app.netlify.com/sites/wilderworld-app/deploys/6229cc31eb894500088ee74d

😎 Browse the preview: https://deploy-preview-408--wilderworld-app.netlify.app/

@domw30 domw30 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@colbr
colbr merged commit fc626a9 into develop Mar 10, 2022
@colbr
colbr deleted the fix/cancel-bid-tweaks branch March 10, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants