Investigate and resolve ‘Cache data may be lost when replacing domains field of a Query object’ error - #412
Merged
Merged
Conversation
…y to resolve warning
|
✔️ Deploy Preview for wilderworld-app ready! 🔨 Explore the source changes: f9ef7dc 🔍 Inspect the deploy log: https://app.netlify.com/sites/wilderworld-app/deploys/622b3f985293380008235365 😎 Browse the preview: https://deploy-preview-412--wilderworld-app.netlify.app/ |
colbr
approved these changes
Mar 13, 2022
colbr
left a comment
Contributor
There was a problem hiding this comment.
Makes sense! Thanks for picking this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Notion Card
1. Pull request checklist
2. PR type
3. What is the old behaviour?
Cache data may be loss - existing and incoming
4. What is the new behaviour?
Warning resolved by adding typePolicies to InMemoryCache
My Findings:
From my understanding, this warning occurs because there is no explicit id or _id property and in Apollo Client 3 the inMemoryCache does not create a fallback fake identifier to normalise the data.
From Apollo Docs:
If you define a merge function for a field, the cache calls that function whenever the field is about to be written with an incoming value (such as from your GraphQL server). When the write occurs, the field's new value is set to the merge function's return value, instead of the original incoming value.
Your merge function cannot push the incoming array directly onto the existing array. It must instead return a new array to prevent potential errors.