Skip to content

Hotfix/ericlow/fix compile error eslint warning - #416

Merged
eric-zero-dev merged 2 commits into
developfrom
hotfix/ericlow/fix-compile-error-eslint-warning
Mar 15, 2022
Merged

Hotfix/ericlow/fix compile error eslint warning#416
eric-zero-dev merged 2 commits into
developfrom
hotfix/ericlow/fix-compile-error-eslint-warning

Conversation

@eric-zero-dev

@eric-zero-dev eric-zero-dev commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

Associated Notion Card


1. Pull request checklist

  • Notion card has been moved to the Code Review column
  • Notion card has a link to this PR
  • A reviewer has been assigned to the Notion card

2. PR type

- Bugfix

3. What is the old behaviour?

  1. There was compile error after merge edit metadata PR because the type definition of Domain has been changed there. There was only 1 place which causes compile error (staking.mock.ts)
  2. There were 2 eslint warnings in develop branch. We need to care about this all the time

4. What is the new behaviour?

All error and warnings disappeared.

5. Other information

@netlify

netlify Bot commented Mar 15, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for wilderworld-app ready!

🔨 Explore the source changes: cb2549e

🔍 Inspect the deploy log: https://app.netlify.com/sites/wilderworld-app/deploys/623057075c8c7e0008973be1

😎 Browse the preview: https://deploy-preview-416--wilderworld-app.netlify.app/

@eric-zero-dev
eric-zero-dev merged commit 7c38cd9 into develop Mar 15, 2022
@eric-zero-dev
eric-zero-dev deleted the hotfix/ericlow/fix-compile-error-eslint-warning branch March 15, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants