fix(buy-now): Use standardised getMetadata method - #453
Merged
Conversation
✅ Deploy Preview for wilderworld-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
padala
reviewed
Mar 30, 2022
eric-zero-dev
approved these changes
Mar 30, 2022
| const { instance: sdk } = useZnsSdk(); | ||
|
|
||
| const getMetadata = async (uri: string) => { | ||
| const raw = await sdk.utility.getMetadataFromUri(uri); |
Contributor
There was a problem hiding this comment.
nit: Let's import import { DomainMetadata } from '@zero-tech/zns-sdk/lib/types'; and use const raw: DomainMetadata = await sdk.utility.getMetadataFromUri(uri);, so that we can know it is converting SDK's DomainMetadata to dApp's Metadata ;
Comment on lines
+31
to
+33
| return { | ||
| getMetadata, | ||
| }; |
Contributor
There was a problem hiding this comment.
Looks great! I think we can add setMetadata and use it in Edit Metadata flow. So getter/setter with hooks. Maybe we can do it later👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Notion Card
1. Pull request checklist
2. PR type
Bugfix/refactoring
3. What is the old behaviour?
SetBuyNowandBuyNowmodals weren't properly parsing metadata.4. What is the new behaviour?
SetBuyNowandBuyNownow usegetMetadatato retrieve metadata.5. Other information