Skip to content

fix: zDAO MVP feedback 3 - #480

Merged
colbr merged 5 commits into
feat/colbr/zdao-sdk-integrationfrom
fix/colbr/zdao-feedback-3
Apr 6, 2022
Merged

fix: zDAO MVP feedback 3#480
colbr merged 5 commits into
feat/colbr/zdao-sdk-integrationfrom
fix/colbr/zdao-feedback-3

Conversation

@colbr

@colbr colbr commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Rd. 3 of feedback

@colbr
colbr requested review from padala and stacy-hunt as code owners April 6, 2022 05:12
@colbr
colbr merged commit e7c291c into feat/colbr/zdao-sdk-integration Apr 6, 2022
@colbr
colbr deleted the fix/colbr/zdao-feedback-3 branch April 6, 2022 05:12
colbr added a commit that referenced this pull request Apr 6, 2022
* DAO Container

* Individual Items

* feat: create static UI elements (#425)

* feat(loading-indicator): make indicator more consistent

* feat(zdao): create initial mock tables

* feat(loading-indicator): handle left and bottom position

* feat(zna-link): use browser position rather than current domain

* feat(zdao-sdk): finish zDAO-SDK implementation

* feat(zdao): new SDK version
This commit has a bug - this should be fixed next commit

* feat(zdao): handle ERC721

* feat(assets-table): handle default asset
For assets which have no image

* fix(assets-table): adjust default logo logic

* feat(dao-page): widget size, default asset, millify
Set max-width of widget to 160px
Set up default asset for DAOs with no logo
Millify total value

* feat(assets-table): remove click handling + hover
Nothing implemented for them yet

* fix(zdao): fixed cursor

* fix(dao-page): proper h1 margin

* feat(generic-table): implement search parameters
Can now provide a key to search by, and text for the input placeholder

* feat(assets-table): make searchable by token ticker

* feat(artwork): allow for subtext which does not append 'wilder.'

* feat(generic-table): add empty message, adjust loading UI
Show empty message when no data is found
Adjusted loading UI so headers don't show while loading

* feat(zdao): add test DAOs for mainnet

* feat(use-redirect): add hook for redirecting

* refactor(zdao): tighten up zdao logic

* feat(zdao): add first breakpoints and DAO table card

* fix(total-provider): prevent duplicate total items

* feat(assets-table): handle ERC721 metadata

* feat(transactions): correct decimal formatting for token amount

* refactor(assets-table): better handling of assets

* Update package-lock.json

* Fix: broken when trying to access a specific DAO - redirects the user to main screen

* Feat: need to be able to search main DAO table by DAO name as well as zNA

* Feat: need to be able to search Assets table by asset name (Wilder World) or asset token ticker (WILD)

* Use constants and types for DAOTable and Grid

* Feat: Add table card for DAO Asset table

* use UUID as unique key for the generic table itemKey

* chore: bump zdao-sdk commit

* Merge remote-tracking branch 'origin/develop' into feat/colbr/zdao-sdk-integration

* feat(dao): container 100% width

* feat: wrap up final touches

* Fix DAO loading issue on mainnet (#478)

* fix: zDAO MVP feedback (#479)

* feat: re-order apps

* fix(number): reset broken formatting

* feat: mainnet DAOs

* feat: got WW NFT images loading correctly

* fix(nft-card): fix missing images

* feat(dao): set up static routing

* feat(zdao): correct safe addresses

* feat(dao-page): add back link

* feat(assets-table): correct detail styling

* feat(dao-table): use correct card styling

* feat(dao): set default icons

* fix(dao): correct header font size

* fix(dao-table): correct zna

* fix(image-card): correct subheader colour

* feat(dao): new default dao icon

* lint: fix warnings

* fix(zdao-sdk-provider): compile error

* fix: zDAO MVP feedback 3 (#480)

* fix(transactions): format values properly

* fix(image): fix bug where cached images would load forever

* refactor(transactions): memoise formatted transactions

* feat(dao): larger back button

* feat(dao): nicer breakpoints, remove wild holders, change label

Co-authored-by: Akshat Mittal <itsreallyakshat@gmail.com>
Co-authored-by: ericlow <eric.low.dev@gmail.com>
Co-authored-by: joon.choi0918 <joon.choi0918@gmail.com>
Co-authored-by: joonchoi0918 <101390821+joonchoi0918@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant