Repository navigation
Conversation
| hide_default_value = true, | ||
| value_hint = ValueHint::DirPath | ||
| )] | ||
| pub(crate) cache_dir: Utf8PathBuf, |
There was a problem hiding this comment.
NB probably need to retain this as a no-op for compatibility, or maybe re-consider adding back a FS caching backend.
| token: GitHubToken, | ||
| base_client: ClientWithMiddleware, | ||
| api_client: ClientWithMiddleware, | ||
| ref_cache: MokaCache<String, Vec<RemoteHead>>, |
There was a problem hiding this comment.
Not sure about this yet, maybe we should keep moka.
7f6ff5f to
4043d38
Compare
4043d38 to
75809c1
Compare
| ``` | ||
|
|
||
| ## Caching between runs | ||
| ## Caching within a run |
There was a problem hiding this comment.
This should be removed and should become a doc stub.
Merging this PR will degrade performance by 25.05%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_zizmor_online_collect_workflows_fast_path |
2.4 s | 4.9 s | -50.05% |
| ❌ | test_zizmor_offline_grafana_9f212d11d0 |
191.7 ms | 235.7 ms | -18.67% |
| ❌ | test_zizmor_startup |
1.6 ms | 2 ms | -18.41% |
| ❌ | test_zizmor_online_gha_hazmat_da3c3cd |
2 s | 2.3 s | -15.77% |
| ❌ | test_zizmor_help |
1.9 ms | 2.2 ms | -15.27% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ww/zizmor-httpcache (75809c1) with main (4cdfcca)
|
I think these perf numbers are unreliable. |
WIP. This is essentially a wholesale lift of uv's
httpcache(with attribution).I'm not sure if I'll use this yet.