Repository navigation
feat(superfluous-actions): allow rust-toolchain on self-hosted runners - #2405
Open
ubiratansoares wants to merge 1 commit into
Open
ubiratansoares wants to merge 1 commit into
ubiratansoares wants to merge 1 commit into
Conversation
ubiratansoares
commented
Sep 22, 2026
Comment on lines
+67
to
+70
| enum SkipCriteria { | ||
| Never, | ||
| SelfHostedRunner, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@woodruffw I don't necessarily love adding a new column to SUPERFLUOUS_ACTIONS, but at least an enum can easily embrance other skip criteria we may get in the future.
Let me know your thoughts on this :)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checks
Please check these boxes:
Mandatory: This PR corresponds to an issue (if not, please create
one first).
Having read the AI policy, I hereby disclose the use of an LLM or other
AI coding assistant in the creation of this PR. PRs will not be rejected
for using AI tools, but will be rejected for undisclosed use or
use that violates the policy.
If a checkbox is not applicable, you can leave it unchecked.
AI disclosure
I did not use AI to write this PR
Summary
Easy follow-up of #2350.
Closes #1865
Test Plan
Added a snapshot test covering this case :)