dependency upgrades - #819
Merged
Merged
Conversation
problame
force-pushed
the
problame/dependency-upgrades
branch
4 times, most recently
from
September 8, 2024 16:31
2701759 to
c0565b5
Compare
Go upgrade: - Go 1.23 is current => use that for release builds - Go 1.22 is less than one year old, it's desirable to support it. - The [`Go Toolchains`](https://go.dev/doc/toolchain) stuff is available in both of these (would also be in Go 1.21). That is quite nice stuff, but required some changes to how we versions we use in CircleCI and the `release-docker` Makefile target. Protobuf upgrade: - Go to protobuf GH release website - Download latest locally - run `sha256sum` - replace existing pinned hashes - `make generate` Deps upgrade: - `go get -t -u all` - repository moves aren't handled well automatically, fix manually - repeat until no changes
problame
force-pushed
the
problame/dependency-upgrades
branch
from
September 8, 2024 21:57
3189801 to
699936c
Compare
Member
Author
|
I think work on this is done. |
This also fixes a deprecation warning.
math/rand.Read is deprecated in newer Go versions. Also, it appears that crypto/rand is faster when used from multiple goroutines: https://gist.github.com/problame/0699acd6f99db4163f26f0b8a61569f3
…nd refactor/extend Makefile a bit)
Doesn't matter much because everything happens inside Docker.
The binary packaging workflow has long since been moved to this repo (I don't think the external workflow work ever completed).
problame
force-pushed
the
problame/dependency-upgrades
branch
from
September 8, 2024 23:19
4cf0fe1 to
3df5e22
Compare
problame
marked this pull request as ready for review
October 18, 2024 12:54
Member
Author
|
Nothing broke, let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.