Skip to content

fix(querylog): add loong64 to unsupported list - #2123

Merged
0xERR0R merged 1 commit into
0xERR0R:mainfrom
rtmongold:fix_loong64_sqlite
Jun 18, 2026
Merged

0xERR0R merged 1 commit into
0xERR0R:mainfrom
rtmongold:fix_loong64_sqlite

Conversation

@rtmongold

Copy link
Copy Markdown
Contributor

Closes #2122

modernc.org/libc v1.22.5 does not support loong64

add loong64 to querylog/database_writer_sqlite.go and querylog/database_writer_sqlite_unsupported.go exclude list.

modernc.org/libc v1.22.5 does not support loong64
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.63%. Comparing base (2496d12) to head (b38ffc7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   87.60%   87.63%   +0.03%     
==========================================
  Files         122      122              
  Lines        9447     9447              
==========================================
+ Hits         8276     8279       +3     
+ Misses        928      925       -3     
  Partials      243      243              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Jun 18, 2026
@0xERR0R 0xERR0R added this to the v0.33.0 milestone Jun 18, 2026

@0xERR0R 0xERR0R left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM 👍

@0xERR0R
0xERR0R merged commit 53cfbda into 0xERR0R:main Jun 18, 2026
14 checks passed
dadezzz pushed a commit to dadezzz/infra_docker-compose that referenced this pull request Jun 21, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/0xerr0r/blocky](https://github.com/0xERR0R/blocky) | patch | `v0.32.0` → `v0.32.1` |

---

### Release Notes

<details>
<summary>0xERR0R/blocky (ghcr.io/0xerr0r/blocky)</summary>

### [`v0.32.1`](https://github.com/0xERR0R/blocky/releases/tag/v0.32.1)

[Compare Source](0xERR0R/blocky@v0.32.0...v0.32.1)

#### Changelog

##### Bug fixes

- [`d3a1fe5`](0xERR0R/blocky@d3a1fe5): fix(dnssec): don't cache transient Indeterminate validation results ([#&#8203;2120](0xERR0R/blocky#2120)) ([#&#8203;2127](0xERR0R/blocky#2127)) ([@&#8203;0xERR0R](https://github.com/0xERR0R))
- [`fc353a0`](0xERR0R/blocky@fc353a0): fix(dnssec): only validate public-upstream answers ([#&#8203;2126](0xERR0R/blocky#2126)) ([#&#8203;2128](0xERR0R/blocky#2128)) ([@&#8203;0xERR0R](https://github.com/0xERR0R))
- [`53cfbda`](0xERR0R/blocky@53cfbda): fix(querylog): add loong64 to unsupported list ([#&#8203;2123](0xERR0R/blocky#2123)) ([@&#8203;rtmongold](https://github.com/rtmongold))

##### Build and dependencies

- [`cad2480`](0xERR0R/blocky@cad2480): build(deps): bump actions/checkout from 6 to 7 ([#&#8203;2124](0xERR0R/blocky#2124)) ([@&#8203;dependabot](https://github.com/dependabot)\[bot])
- [`6ff7db7`](0xERR0R/blocky@6ff7db7): build(deps): bump github.com/moby/moby/api from 1.54.2 to 1.55.0 ([#&#8203;2125](0xERR0R/blocky#2125)) ([@&#8203;dependabot](https://github.com/dependabot)\[bot])

***

#### ❤️ Support Blocky

Blocky is free and open source, developed in my spare time — no telemetry, no ads, no hidden
filtering. If it's useful to you, please consider supporting its continued development:

[GitHub Sponsors](https://github.com/sponsors/0xERR0R) ·
[thanks.dev](https://thanks.dev/u/gh/0xERR0R) ·
[Liberapay](https://liberapay.com/spx01) ·
[Ko-fi](https://ko-fi.com/0xerr0r) ·
[PayPal](https://paypal.me/spx01)

Thank you to everyone supporting Blocky! 🙏

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMjIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjIyMi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
0xERR0R added a commit to drscream/blocky that referenced this pull request Sep 5, 2026
53cfbda (0xERR0R#2123) excluded linux/loong64 from the SQLite query log because the
pure-Go driver chain (modernc.org/sqlite -> modernc.org/libc) ships no generated
code for it, but it only updated the two implementation files.

database_writer_test.go imports github.com/glebarez/sqlite directly and carries
its own copy of the constraint, which was left untouched. As a result the test
binary still pulls in the driver and fails to compile:

    $ GOOS=linux GOARCH=loong64 go vet ./querylog/
    package github.com/0xERR0R/blocky/querylog (test)
        imports github.com/glebarez/sqlite
        imports modernc.org/libc/errno: build constraints exclude all Go files

Add the missing loong64 term so the three constraints stay in sync.

Claude-Session: https://claude.ai/code/session_01X2Dg33aFoCW4AvWQasX5rX
0xERR0R added a commit to drscream/blocky that referenced this pull request Sep 5, 2026
The note listing where the sqlite target is unavailable was incomplete: it
never picked up loong64 from 0xERR0R#2123, did not mention Solaris/illumos, and
omitted the mips/mipsle variants of the BSD release targets.

Restate it as the actual rule behind the build constraint and then give the
affected official release builds. Verified against `go list` on every target
in .goreleaser.yml that exactly these eleven select the stub, and that all
remaining ones keep the real driver.

Claude-Session: https://claude.ai/code/session_01X2Dg33aFoCW4AvWQasX5rX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loong64 build failure due to modernc.org/libc v1.22.5

2 participants