Repository navigation
fix(querylog): add loong64 to unsupported list - #2123
Merged
Merged
Conversation
modernc.org/libc v1.22.5 does not support loong64
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
==========================================
+ Coverage 87.60% 87.63% +0.03%
==========================================
Files 122 122
Lines 9447 9447
==========================================
+ Hits 8276 8279 +3
+ Misses 928 925 -3
Partials 243 243 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0xERR0R
approved these changes
Jun 18, 2026
0xERR0R
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution, LGTM 👍
dadezzz
pushed a commit
to dadezzz/infra_docker-compose
that referenced
this pull request
Jun 21, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/0xerr0r/blocky](https://github.com/0xERR0R/blocky) | patch | `v0.32.0` → `v0.32.1` | --- ### Release Notes <details> <summary>0xERR0R/blocky (ghcr.io/0xerr0r/blocky)</summary> ### [`v0.32.1`](https://github.com/0xERR0R/blocky/releases/tag/v0.32.1) [Compare Source](0xERR0R/blocky@v0.32.0...v0.32.1) #### Changelog ##### Bug fixes - [`d3a1fe5`](0xERR0R/blocky@d3a1fe5): fix(dnssec): don't cache transient Indeterminate validation results ([#​2120](0xERR0R/blocky#2120)) ([#​2127](0xERR0R/blocky#2127)) ([@​0xERR0R](https://github.com/0xERR0R)) - [`fc353a0`](0xERR0R/blocky@fc353a0): fix(dnssec): only validate public-upstream answers ([#​2126](0xERR0R/blocky#2126)) ([#​2128](0xERR0R/blocky#2128)) ([@​0xERR0R](https://github.com/0xERR0R)) - [`53cfbda`](0xERR0R/blocky@53cfbda): fix(querylog): add loong64 to unsupported list ([#​2123](0xERR0R/blocky#2123)) ([@​rtmongold](https://github.com/rtmongold)) ##### Build and dependencies - [`cad2480`](0xERR0R/blocky@cad2480): build(deps): bump actions/checkout from 6 to 7 ([#​2124](0xERR0R/blocky#2124)) ([@​dependabot](https://github.com/dependabot)\[bot]) - [`6ff7db7`](0xERR0R/blocky@6ff7db7): build(deps): bump github.com/moby/moby/api from 1.54.2 to 1.55.0 ([#​2125](0xERR0R/blocky#2125)) ([@​dependabot](https://github.com/dependabot)\[bot]) *** #### ❤️ Support Blocky Blocky is free and open source, developed in my spare time — no telemetry, no ads, no hidden filtering. If it's useful to you, please consider supporting its continued development: [GitHub Sponsors](https://github.com/sponsors/0xERR0R) · [thanks.dev](https://thanks.dev/u/gh/0xERR0R) · [Liberapay](https://liberapay.com/spx01) · [Ko-fi](https://ko-fi.com/0xerr0r) · [PayPal](https://paypal.me/spx01) Thank you to everyone supporting Blocky! 🙏 </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMjIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjIyMi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
0xERR0R
added a commit
to drscream/blocky
that referenced
this pull request
Sep 5, 2026
53cfbda (0xERR0R#2123) excluded linux/loong64 from the SQLite query log because the pure-Go driver chain (modernc.org/sqlite -> modernc.org/libc) ships no generated code for it, but it only updated the two implementation files. database_writer_test.go imports github.com/glebarez/sqlite directly and carries its own copy of the constraint, which was left untouched. As a result the test binary still pulls in the driver and fails to compile: $ GOOS=linux GOARCH=loong64 go vet ./querylog/ package github.com/0xERR0R/blocky/querylog (test) imports github.com/glebarez/sqlite imports modernc.org/libc/errno: build constraints exclude all Go files Add the missing loong64 term so the three constraints stay in sync. Claude-Session: https://claude.ai/code/session_01X2Dg33aFoCW4AvWQasX5rX
0xERR0R
added a commit
to drscream/blocky
that referenced
this pull request
Sep 5, 2026
The note listing where the sqlite target is unavailable was incomplete: it never picked up loong64 from 0xERR0R#2123, did not mention Solaris/illumos, and omitted the mips/mipsle variants of the BSD release targets. Restate it as the actual rule behind the build constraint and then give the affected official release builds. Verified against `go list` on every target in .goreleaser.yml that exactly these eleven select the stub, and that all remaining ones keep the real driver. Claude-Session: https://claude.ai/code/session_01X2Dg33aFoCW4AvWQasX5rX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2122
modernc.org/libc v1.22.5 does not support loong64
add loong64 to querylog/database_writer_sqlite.go and querylog/database_writer_sqlite_unsupported.go exclude list.