Apply babbaj's third and fourth reviews of the Java pathfinder - #22
Merged
Merged
Conversation
Brings back 0Mattias/baritone 65d533a3 from the fork's java-nether-pathfinder branch, the fix for babbaj's third review of cabaletta/baritone#5117, as #20 and #21 did for the earlier reviews. A block update asks its state isAir instead of comparing it against Blocks.AIR's default state, so a block that became cave air no longer counts as solid, and a single block update agrees with writeChunkData, which already treats cave air as air when it packs a whole chunk. AIR_BLOCK_STATE had no other use and goes. The pathfinder package is untouched and stays byte for byte the branch's. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Brings back 0Mattias/baritone eb62fc04 from the fork's java-nether-pathfinder branch, babbaj's next comment on cabaletta/baritone#5117. Face only named the six directions and moved a BlockPos along one, which Direction and BlockPos.relative already do, so the enum goes and PathFinder takes a Direction. The neighbour array keeps the native library's order, UP, DOWN, NORTH, SOUTH, EAST, WEST, rather than Direction.values(), so the search expands neighbours as it always has. The pathfinder package stays byte for byte the branch's, modulo the package name and the licence header. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babbaj added two one-comment reviews to cabaletta/baritone#5117 after approving it, and this brings them back from the fork's
java-nether-pathfinderbranch (0Mattias/baritone65d533a3andeb62fc04), the way #20 and #21 did for the earlier reviews.isAir()instead of comparing it againstBlocks.AIR's default state, so a block that became cave air no longer counts as solid, and a single block update agrees with the whole-chunk packer, which already treats cave air as air;AIR_BLOCK_STATEhad no other use and goesFaceenum is deleted in favour of Minecraft'sDirection:PathFindertakes aDirectionand moves withBlockPos.relative, and the neighbour array keeps the native library's order (UP, DOWN, NORTH, SOUTH, EAST, WEST) rather thanDirection.values(), so the A* search expands neighbours as it always hasThe pathfinder package stays byte for byte the branch's, modulo the package name and the licence header. All 102 unit tests pass locally, and the four in-world elytra flights pass on this branch.
🤖 Generated with Claude Code